Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uninitialized jumpdests fallback #1148

Merged
merged 2 commits into from
May 21, 2024
Merged

feat: uninitialized jumpdests fallback #1148

merged 2 commits into from
May 21, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented May 17, 2024 •
edited
Loading

Time spent on this PR: 0.5d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • Adds a fallback so that if a jumpdest index read is 0 and the jumpdests have not been initialized, initialize them and re-query the index

This change is Reviewable

@enitrat enitrat changed the title wip feat: uninitialized jumpdests fallback May 17, 2024
@enitrat enitrat force-pushed the feat/unstored-jumpdests-fallback branch from 4fdf348 to b39c467 Compare May 17, 2024 10:49
@enitrat enitrat force-pushed the feat/unstored-jumpdests-fallback branch from b39c467 to 4f0ed76 Compare May 17, 2024 10:55
@enitrat enitrat marked this pull request as ready for review May 21, 2024 09:23
@ClementWalter ClementWalter merged commit 3aacc3a into main May 21, 2024
7 checks passed
@ClementWalter ClementWalter deleted the feat/unstored-jumpdests-fallback branch May 21, 2024 10:13
@ClementWalter ClementWalter mentioned this pull request May 30, 2024
Merged
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
@edisontim
enh: eth provider errors (kkrt-labs#1148)
1189836 
* Add information in eth provider errors

* Change string types to more explicit types

* Address PR comment: change number to b256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter ClementWalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @ClementWalter