feat: cairo precompiles #1149
Merged
feat: cairo precompiles #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/cairo-precompiles
branch
3 times, most recently
from
d0696fe
to
1b2fe5e
Compare
enitrat
force-pushed
the
feat/cairo-precompiles
branch
from
9ea5966
to
c99a18d
Compare
| (bool success, bytes memory result) = CAIRO_PRECOMPILE_ADDRESS.call(callData); | ||
| require(success, "CairoLib: call_contract failed"); | ||
|
|
||
| returnData = result; |
There was a problem hiding this comment.
if you name the returned value, you can skip this and use the same name directly. I my self prefer not to name it and use the return statement, more explicit imo
ClementWalter
approved these changes
May 29, 2024
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
refactor tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
This change is