Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade kakarot 0.8.0 on kakarot sepolia #1150

Merged
merged 1 commit into from
May 23, 2024
Merged

upgrade kakarot 0.8.0 on kakarot sepolia #1150

merged 1 commit into from
May 23, 2024

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented May 22, 2024 •
edited by ClementWalter
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • upgrade kakarot to v0.8.0

This change is Reviewable

enitrat
enitrat reviewed May 22, 2024
View reviewed changes
deployments/kakarot-sepolia/declarations.json
"account_contract_fixture": "0x2c2520d81c315969597b2f7a0189db1b65ec19da02fe40c40d183e2e9bfb3c8",
"kakarot": "0x7e5e97d10a2db3957687ba0a4bb5afde05bf7468871514af416d70badb711f8",
"account_contract": "0x3c1081f98ecdd1d320368d2a136191a3fbf02a3e419463d77c3c5aa6dbc99a0",
"account_contract_fixture": "0x5e823aa6a4468e35903689615b834fe280a1f6a039b22d0d577f551a50cda03",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account_contract_fixture EVM Cairo1HelpersFixture are not meant to be declared on prod networks, they're only classes used for tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were they declared?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, shouldnt be on testnets, only devnets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because well, currently there is nothing in the DECLARED_CONTRACTS constant to give such information!

You could add a 'only_devnet': bool in (https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/constants.py#L185)

and filter in https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/deploy_kakarot.py#L38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that it's not been done yet because it was especially made it possible to run the end-to-end tests against any RPC (e.g. starknet testnet), but it's not been used so far

@enitrat enitrat merged commit d939a3c into main May 23, 2024
7 checks passed
@enitrat enitrat deleted the chore/upgrade_kakarot_0_8_0 branch May 23, 2024 16:32
@ClementWalter ClementWalter mentioned this pull request May 30, 2024
Merged
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
@greged93
fix: error handling (kkrt-labs#1150)
46d630d 
fix error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat left review comments

@ClementWalter ClementWalter ClementWalter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eikix @ClementWalter @enitrat