-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unpack packed calldata #1178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should just reused what exists in accounts.library for loading stored packed bytecode
calldata be encoded as
calldata[0] is bytecode_len
calldata + 1 is stored packed bytecode
and should work
enitrat
force-pushed
the
feat/unpack-calldata
branch
2 times, most recently
from
June 5, 2024 14:13
41485d8
to
78a79a5
Compare
enitrat
commented
Jun 5, 2024
enitrat
force-pushed
the
feat/unpack-calldata
branch
from
June 6, 2024 10:05
d89aeac
to
7d880f7
Compare
ClementWalter
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 1.3d
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1175
What is the new behavior?
This change is