Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: signature extension #1184

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Jun 6, 2024

Time spent on this PR: 0.1 day

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Signature was extended to length of 6 assuming signature would impact the hash computation.

Resolves #1183

What is the new behavior?

Reverted #1162


This change is Reviewable

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Mathieu <60658558+enitrat@users.noreply.github.com>
@enitrat enitrat merged commit b5da414 into kkrt-labs:main Jun 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: revert signature change
2 participants