Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeploy + some fixes #1196

Merged
merged 4 commits into from
Jun 10, 2024
Merged

redeploy + some fixes #1196

merged 4 commits into from
Jun 10, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Jun 10, 2024

Time spent on this PR: 0.3 day

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Staging can't run correctly currently.

Resolves #NA

What is the new behavior?

  • Upgrades Kakarot on staging
  • Adds a type of network "staging" which allows upgrades but also uses the "EVM" fixture.

This change is Reviewable

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so

        deployments["Counter"] = await deploy("Counter")
        deployments["MockPragmaOracle"] = await deploy("MockPragmaOracle")

were failing on staging? why?

It's ok for me to merge like that but it looks like we miss a NETWORK["type"] that would be an enum (prod/stating/local) instead of addinga a regex like condition on the name for deciding if it's staging

@greged93
Copy link
Contributor Author

greged93 commented Jun 10, 2024

can add the enum, that makes more sense.

I missed the Counter and MockPragmaOracle actually. These aren't merged yet on the commit I am using for the submodule. I guess we should also deploy these in the same way as the EVM, let me update this.

What did fail was that setting the Network to "devnet" caused it to redeploy all the time instead of upgrading which isn't what we were looking for.

@ClementWalter ClementWalter merged commit a63a987 into kkrt-labs:main Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants