This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 325
dev(scripts): split deployment concerns in multiple files #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7be1d6
to
be5c816
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=====================================
Coverage 61.8% 61.8%
=====================================
Files 44 44
Lines 8197 8197
=====================================
Hits 5069 5069
Misses 3128 3128 ☔ View full report in Codecov by Sentry. |
ClementWalter
suggested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add separator # %%
for each section as it's more convenient to run some part on jupyter when required
ClementWalter
previously approved these changes
Oct 11, 2024
759bb3b
to
1ebfb5e
Compare
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* set staging accounts Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * rename + update e2e pipeline workflow and script Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * update GH_TOKEN to GITHUB_TOKEN Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * update urls Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix addresses Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix script + karnot config Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * typos Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * skip CairoPrecompiles Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix e2e pipeline script Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * revert changes to other files Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * update workflow Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix workflow fmt Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * use github token in action Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> --------- Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the deployment flow in multiple files. leverage the "lazy execution"
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)