Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

dev(scripts): split deployment concerns in multiple files #1495

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 10, 2024

Splits the deployment flow in multiple files. leverage the "lazy execution"


This change is Reviewable

@enitrat enitrat force-pushed the dev/deploy-scripts branch from e7be1d6 to be5c816 Compare October 10, 2024 19:56
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.8%. Comparing base (f7eacc8) to head (1ebfb5e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1495   +/-   ##
=====================================
  Coverage   61.8%   61.8%           
=====================================
  Files         44      44           
  Lines       8197    8197           
=====================================
  Hits        5069    5069           
  Misses      3128    3128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add separator # %% for each section as it's more convenient to run some part on jupyter when required

ClementWalter
ClementWalter previously approved these changes Oct 11, 2024
@enitrat enitrat force-pushed the dev/deploy-scripts branch from 759bb3b to 1ebfb5e Compare October 11, 2024 12:35
@enitrat enitrat merged commit 9c83960 into main Oct 11, 2024
16 checks passed
@enitrat enitrat deleted the dev/deploy-scripts branch October 11, 2024 13:28
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* set staging accounts

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* rename + update e2e pipeline workflow and script

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* update GH_TOKEN to GITHUB_TOKEN

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* update urls

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* fix addresses

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* fix script + karnot config

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* typos

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* skip CairoPrecompiles

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* fix e2e pipeline script

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* revert changes to other files

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* update workflow

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* fix workflow fmt

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* use github token in action

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

* add comments

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>

---------

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants