Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

dev: setup script #1502

Merged
merged 7 commits into from
Oct 18, 2024
Merged

dev: setup script #1502

merged 7 commits into from
Oct 18, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 11, 2024

Closes #1500


This change is Reviewable

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 11, 2024

@Eikix can you try make setup with this and check all runs fine now?

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against a simple script for doing this though more ad hoc tools exist. Just bear in mind then that

  • the python version requirement for the script should be as low as possible so that almost anyone can run it
  • only python should be required to run it and all the tools added therein (missing uv currently if I'm not mistaken)

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 14, 2024

i consider that uv needs to be manually installed to run this script. perhaps its a mistake? but because it's a python script, it needs python to run anyway 🤔

@enitrat
Copy link
Collaborator Author

enitrat commented Oct 14, 2024

modified the makefile to use raw python and installed uv in the script.

ClementWalter
ClementWalter previously approved these changes Oct 16, 2024
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging could be a bit nicer, and submodule updated but tested and it's already nice

@enitrat enitrat merged commit e5455d2 into main Oct 18, 2024
14 checks passed
@enitrat enitrat deleted the dev/setup-script branch October 18, 2024 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: supercharge make setup
2 participants