Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: MulticallCairo precompile #1503

Merged
merged 12 commits into from
Oct 15, 2024
Merged

feat: MulticallCairo precompile #1503

merged 12 commits into from
Oct 15, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 12, 2024

Time spent on this PR: 0.5d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1464

What is the new behavior?

  • Implements the MulticallCairo precompile - at address 0x75003, that receives an flattened array of cairo calls and executes them sequentially.
  • Permisionless precompile: anyone can call it, unlike 0x75001
  • ⚠️ For security purposes this precompile CANNOT be called with DELEGATECALL or CALLCODE ⚠️
  • Ignores return data of the Cairo calls
    • Highlights the requirement of a SinglecallCairo precompile that would be permissionless, and also have delegatecall deactivated ?

This change is Reviewable

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 66.50246% with 68 lines in your changes missing coverage. Please review.

Project coverage is 61.7%. Comparing base (9c83960) to head (5f495e7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...zero/kakarot/precompiles/kakarot_precompiles.cairo 63.5% 58 Missing ⚠️
...zero/kakarot/precompiles/precompiles_helpers.cairo 78.7% 7 Missing ⚠️
cairo_zero/kakarot/precompiles/precompiles.cairo 71.4% 2 Missing ⚠️
cairo_zero/kakarot/interpreter.cairo 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1503     +/-   ##
=======================================
- Coverage   61.9%   61.7%   -0.2%     
=======================================
  Files         44      44             
  Lines       8197    8327    +130     
=======================================
+ Hits        5078    5144     +66     
- Misses      3119    3183     +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat force-pushed the feat/batch-call-precompiles branch 2 times, most recently from dba5f03 to 4d2d372 Compare October 14, 2024 16:39
@enitrat enitrat force-pushed the feat/batch-call-precompiles branch from 4d2d372 to c1caa88 Compare October 14, 2024 17:16
@enitrat enitrat merged commit 44f25fd into main Oct 15, 2024
15 of 16 checks passed
@enitrat enitrat deleted the feat/batch-call-precompiles branch October 15, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: multicall cairo precompile
3 participants