This repository was archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
commented
Oct 12, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 13, 2024
obatirou
reviewed
Oct 14, 2024
solidity_contracts/src/CairoPrecompiles/MulticallCairoCounterCaller.sol
Outdated
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/MulticallCairoCounterCaller.sol
Outdated
Show resolved
Hide resolved
obatirou
reviewed
Oct 14, 2024
obatirou
reviewed
Oct 14, 2024
solidity_contracts/src/CairoPrecompiles/MulticallCairoCounterCaller.sol
Outdated
Show resolved
Hide resolved
obatirou
reviewed
Oct 14, 2024
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
obatirou
reviewed
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
=======================================
- Coverage 61.9% 61.7% -0.2%
=======================================
Files 44 44
Lines 8197 8327 +130
=======================================
+ Hits 5078 5144 +66
- Misses 3119 3183 +64 ☔ View full report in Codecov by Sentry. |
solidity_contracts/src/CairoPrecompiles/MulticallCairoCounterCaller.sol
Outdated
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/MulticallCairoCounterCaller.sol
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
dba5f03
to
4d2d372
Compare
4d2d372
to
c1caa88
Compare
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_batch_cairo_precompile.py
Outdated
Show resolved
Hide resolved
ClementWalter
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5d
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1464
What is the new behavior?
MulticallCairo
precompile - at address0x75003
, that receives an flattened array of cairo calls and executes them sequentially.0x75001
SinglecallCairo
precompile that would be permissionless, and also have delegatecall deactivated ?This change is