This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
fix: returndata of create txs #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
fix/returndata-create-tx-address
branch
from
b4aa867 to
f6c569f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
=======================================
+ Coverage 61.9% 63.4% +1.5%
=======================================
Files 44 44
Lines 8335 8335
=======================================
+ Hits 5160 5290 +130
+ Misses 3175 3045 -130 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the returndata of create txs, which was pushing
[<sn_addr>, <evm_addr>]instead of[<contract_code>]in the returndata.side note: the SSJ test would not run because it's ignored. There is some work regarding testing of SSJ which is out of scope for now.
This change is