Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

[KGA-80] [KGA-137] [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation #1565

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 4, 2024

Fixes validation of ecrecover r and s values.
Fixes the library call 'mock' to throw error if an invalid values reaches this point.

Fix for: code-423n4/2024-09-kakarot-findings#13


This change is Reviewable

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.4%. Comparing base (6cbc820) to head (a7751e2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1565     +/-   ##
=======================================
- Coverage   63.4%   63.4%   -0.1%     
=======================================
  Files         44      44             
  Lines       8335    8348     +13     
=======================================
+ Hits        5292    5298      +6     
- Misses      3043    3050      +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enitrat enitrat force-pushed the fix/ecrecover-validation branch from c93cc5c to 3687f84 Compare November 4, 2024 06:27
@ClementWalter ClementWalter merged commit 26fe525 into main Nov 4, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/ecrecover-validation branch November 4, 2024 13:01
@ClementWalter ClementWalter changed the title fix: ecrecover validation [KGA-83] fix: ecrecover validation Nov 4, 2024
Copy link

@ClementWalter ClementWalter changed the title [KGA-83] fix: ecrecover validation [KGA-109] [KGA-83] fix: ecrecover validation Nov 4, 2024
Copy link

@ClementWalter ClementWalter changed the title [KGA-109] [KGA-83] fix: ecrecover validation [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation Nov 4, 2024
@ClementWalter ClementWalter changed the title [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation [KGA-137] [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation Nov 4, 2024
Copy link

@enitrat enitrat changed the title [KGA-137] [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation [KGA-80] [KGA-137] [KGA-126] [KGA-109] [KGA-83] fix: ecrecover validation Nov 21, 2024
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants