Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-77] [KGA-35] [KGA-7] fix: DualVMToken totalSupply #1569

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 4, 2024

Fixes an issue where totalSupply was skipping the high-part of the u256 reported in code-423n4/2024-09-kakarot-findings#32

  • Correctly deserialize return value
  • Update test to launch a token with populated (low, high) parts of the u256 struct

This change is Reviewable

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.3%. Comparing base (6cbc820) to head (0e01363).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1569     +/-   ##
=======================================
- Coverage   63.4%   63.3%   -0.2%     
=======================================
  Files         44      44             
  Lines       8335    8335             
=======================================
- Hits        5292    5278     -14     
- Misses      3043    3057     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit dc11293 into main Nov 4, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix-DualVmToken-totalSupply branch November 4, 2024 13:01
@ClementWalter ClementWalter changed the title fix: DualVMToken totalSupply [KGA-77] fix: DualVMToken totalSupply Nov 4, 2024
Copy link

@obatirou obatirou changed the title [KGA-77] fix: DualVMToken totalSupply [KGA-77] [KGA-35] [KGA-7] fix: DualVMToken totalSupply Nov 8, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants