Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-32] [KGA-143] [KGA-86] [KGA-88]fix: last 10 blockhash are 0 #1593

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Nov 8, 2024

code-423n4/2024-09-kakarot-findings#5

What is the new behavior?

Last 10 blocks returns 0 for blockhash


This change is Reviewable

Copy link

Copy link

Copy link

Copy link

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check why this is still marked as xfail?

    class TestBlockhash:
        @pytest.mark.xfail(reason="Need to fix blockhash on real Starknet network")
        async def test_should_return_blockhash_with_valid_block_number(
            self, plain_opcodes, block_number, block_hash
        ):
            blockhash = await plain_opcodes.opcodeBlockHash(
                await block_number("latest")
            )

            assert int.from_bytes(blockhash, byteorder="big") == await block_hash()

@ClementWalter ClementWalter merged commit d962582 into kkrt-labs:main Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants