This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Add test case for issue 683 & 684 #767
Merged
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
changed the title
ClementWalter
changed the title
ClementWalter
force-pushed
the
cw/add-dec-example
branch
2 times, most recently
from
f097b07 to
5deb2a4
Compare
ClementWalter
force-pushed
the
cw/add-dec-example
branch
from
5deb2a4 to
390b4d5
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 69.40% 69.33% -0.08%
==========================================
Files 42 42
Lines 6779 6779
==========================================
- Hits 4705 4700 -5
- Misses 2074 2079 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.05
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Kakarot doesn't revert when doing
0 - 1foruint256.There was already an issue, I just added a test.
What is the new behavior?
Still not passing