-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fast_exp #809
Merged
Merged
feat: fast_exp #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 71.42% 71.46% +0.04%
==========================================
Files 45 45
Lines 6100 6109 +9
==========================================
+ Hits 4357 4366 +9
Misses 1743 1743 ☔ View full report in Codecov by Sentry. |
Eikix
commented
Nov 14, 2023
ClementWalter
previously approved these changes
Nov 16, 2023
Eikix
force-pushed
the
fix/u256_exponentiation
branch
from
November 16, 2023 14:14
020573c
to
bff3b7a
Compare
ClementWalter
approved these changes
Nov 16, 2023
I think we could try to uncomment some of the exponentiation tests from the ef-tests with this |
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* add hive in ci * fix hive_chain copy in dockerfile * load hive image into docker * build hive chain binary * add logs * fix build copy * try absolute path for lib kakarot * fix copy * copy kakarot build * fix build copy * try to fix again * fix artifacts * add workdir in copy * relative path kakarot * copying the project for compiler * try * fix * fix * only run rpc test * fix rpc dockerfile * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #700
What is the new behavior?