Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe uint256 sub #824

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

ClementWalter
Copy link
Member

Time spent on this PR: 0.1

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

A test is marked as failed while it has the expected behavior
No test for safe sub.

Resolves #683

What is the new behavior?

Fixed tests.
Behavior was already correct.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (806ea6b) 71.84% compared to head (98b8507) 72.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   71.84%   72.11%   +0.27%     
==========================================
  Files          47       47              
  Lines        6046     6040       -6     
==========================================
+ Hits         4344     4356      +12     
+ Misses       1702     1684      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ClementWalter ClementWalter merged commit 477dc4d into kkrt-labs:main Nov 23, 2023
6 of 7 checks passed
@ClementWalter ClementWalter deleted the cw/fix-counter-tests branch November 23, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: decrementing 0 should fail, but it's getting successful transaction
2 participants