Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addmod impl #865

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix: addmod impl #865

merged 2 commits into from
Jan 8, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Jan 8, 2024

Time spent on this PR: 0.5d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #695 Resolves #691

What is the new behavior?

  • Fixed the addmod implementation

@ClementWalter ClementWalter merged commit 2dafae1 into main Jan 8, 2024
10 checks passed
@ClementWalter ClementWalter deleted the fix/addmod-impl branch January 8, 2024 17:08
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* add inlines

* remove unnecessary trait bounds and functions

* refactor error handling

* fix tests

* fix rebasing

* add docs

* lint

* update log_map_err API

* use `inspect_err`

* fix rebasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ADDMOD performs operations MOD 2^256 bug: addmod not working properly when stressed
2 participants