Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove useless computation in uint256_fast_exp #151

Closed
Tracked by #131
obatirou opened this issue Nov 28, 2024 · 0 comments · Fixed by #194
Closed
Tracked by #131

fix: remove useless computation in uint256_fast_exp #151

obatirou opened this issue Nov 28, 2024 · 0 comments · Fixed by #194
Assignees
@obatirou
Milestone
EF tests

Comments

@obatirou
Copy link
Contributor

obatirou commented Nov 28, 2024 •
edited
Loading

kkrt-labs/kakarot#1603
@obatirou obatirou mentioned this issue Nov 28, 2024
Closed
@github-project-automation github-project-automation bot moved this to Backlog in Keth Nov 28, 2024
@obatirou obatirou added this to the EF tests no state root milestone Nov 28, 2024
@obatirou obatirou self-assigned this Dec 2, 2024
@obatirou obatirou moved this from Backlog to In review in Keth Dec 2, 2024
@obatirou obatirou mentioned this issue Dec 2, 2024
Merged
ClementWalter pushed a commit that referenced this issue Dec 3, 2024
@obatirou
dev: remove useless computation in uint256_fast_exp (#194)
74efed7 
Closes #151

Remove useless computation in `uint256_fast_exp`

Note to reviewer: this is a fix imported from C4 mitigation, ensure the
fix was correctly ported by looking at the corresponding issue and PR.
@github-project-automation github-project-automation bot moved this from In review to Done in Keth Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obatirou obatirou

Labels
None yet
Projects
Keth
Status: Done
Milestone
EF tests
Development

Successfully merging a pull request may close this issue.

dev: remove useless computation in uint256_fast_exp obatirou/keth
1 participant
@obatirou