Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: use low level ret after an assert 0 = 1 #704

Closed
ClementWalter opened this issue Feb 7, 2025 · 0 comments · Fixed by #705
Closed

dev: use low level ret after an assert 0 = 1 #704

ClementWalter opened this issue Feb 7, 2025 · 0 comments · Fixed by #705
Assignees

Comments

@ClementWalter
Copy link
Member

Why

In some places, we need to raise surely with an assert 0 = 1 (branch should not be run) nut still need to return something to comply with the compiler expected return type.

Currently, we build useless objects that are actually never returned, and it impacts falsy the coverage.

What

Don't build fake object for the sake of making the compiler happy.

How

Just use a low level ret.

@ClementWalter ClementWalter moved this to Todo in Keth Feb 7, 2025
@Eikix Eikix self-assigned this Feb 7, 2025
@Eikix Eikix moved this from Todo to In progress in Keth Feb 7, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Keth Feb 7, 2025
@Eikix Eikix added this to the EELS migration milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants