Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ret instead of 0 return #705

Merged
merged 1 commit into from
Feb 7, 2025
Merged

use ret instead of 0 return #705

merged 1 commit into from
Feb 7, 2025

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 7, 2025

closes #704

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use when we had to built a return struct or type, but don't add new returns

@Eikix
Copy link
Member Author

Eikix commented Feb 7, 2025

just use when we had to built a return struct or type, but don't add new returns

thanks, done

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 66.28%. Comparing base (7321d91) to head (c5fa531).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cairo/ethereum/cancun/transactions_types.cairo 0.00% 9 Missing ⚠️
cairo/ethereum/cancun/state.cairo 0.00% 2 Missing ⚠️
cairo/ethereum/cancun/transactions.cairo 0.00% 2 Missing ⚠️
cairo/ethereum/cancun/trie.cairo 0.00% 2 Missing ⚠️
cairo/ethereum_rlp/rlp.cairo 0.00% 2 Missing ⚠️
cairo/ethereum/cancun/utils/address.cairo 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   66.21%   66.28%   +0.06%     
==========================================
  Files          88       88              
  Lines       20493    20527      +34     
==========================================
+ Hits        13570    13606      +36     
+ Misses       6923     6921       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit bee0671 into main Feb 7, 2025
10 of 11 checks passed
@ClementWalter ClementWalter deleted the cov/ret branch February 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: use low level ret after an assert 0 = 1
3 participants