Skip to content

Missing blacklisting handlers in DBManager #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karelpak1 opened this issue Feb 1, 2024 · 2 comments
Closed

Missing blacklisting handlers in DBManager #99

karelpak1 opened this issue Feb 1, 2024 · 2 comments
Assignees
Labels
priority: medium This has a medium priority

Comments

@karelpak1
Copy link

karelpak1 commented Feb 1, 2024

Describe the bug
Missing handlers in DatabaseManager regarding blacklisting + schema? Which means, blacklisting is practically not functional. Also I read updates.md and this feature was removed (why?) in 6.0.0, sadly code is still present (in owner cog) and should be removed, if not planned for future use.

To Reproduce
Steps to reproduce the behavior:

  1. /blacklist add {user}
  2. /blacklist remove {user}
  3. /blacklist show
  4. See all errors

Expected behavior
Add/remove user to blacklist.
Show users in blacklist.

Screenshots
None

Template Version
6.1.1 - 1bb7963

Additional context
None

@kkrypt0nn kkrypt0nn self-assigned this Feb 1, 2024
@kkrypt0nn kkrypt0nn added the priority: medium This has a medium priority label Feb 1, 2024
@karelpak1
Copy link
Author

karelpak1 commented Feb 1, 2024

What is your plan @kkrypt0nn? Add blacklist support back or remove it completely? I can easily make a PR with added blacklist support. I've already tested it and practically it's taken from the old version of db_manager and everything rewritten in database init.

@kkrypt0nn
Copy link
Owner

Planned to remove it, as it was my intention - there's no real reason to have blacklists especially storing them in a database like I previously did.

The problem is resource-wise it's not smart to make a database query every time a message is sent or slash command is executed. If someone wants to have one, would make sense to hard-code the IDs and check with those rather than making database queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This has a medium priority
Projects
None yet
Development

No branches or pull requests

2 participants