Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deploy instead of publish #14

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

arnarthor
Copy link
Contributor

@arnarthor arnarthor commented Sep 27, 2023

The package keeps giving a deprecation warning about the publish command.

I've been using this with patch-package at work and it's working fine.

Fixes #8

@klaascuvelier
Copy link
Owner

Hey @arnarthor thanks for this PR.
I am trying to find the first version of wrangler where you can use pages deploy instead of pages publish so I can appropriately update the peerDeps in package.json. Would you know by any chance?

@arnarthor
Copy link
Contributor Author

Not sure, I was trying to search through their changelogs but couldn't find it. Sorry

@klaascuvelier
Copy link
Owner

It seems like it's only starting in wrangler v3 they added this message. Are you on v3 @arnarthor ?

@klaascuvelier klaascuvelier merged commit a1421c8 into klaascuvelier:main Oct 6, 2023
@klaascuvelier
Copy link
Owner

Merged your MR already after I did an update to package.json for the wrangler package that updates to v3.
Still would like to know what version you were already using :)

@arnarthor
Copy link
Contributor Author

Yeah sorry about that. Forgot to reply to this.

I'm using Wrangler 3.9.0 in my project. I decided to override the dependency since there was some feature that I needed for my site that was recently released.

I just set up the project around a month ago so I had no backwards compatibility issues to deal with.

@klaascuvelier
Copy link
Owner

Alright thanks for confirming. That's cool.
I am preparing the release with wrangler 3 support, should be out later this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use wrangler v3 and update deprecated deploy command
2 participants