Zstd optimize small blocks #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives big boost on small block/high concurrency.
# Conflicts: # huff0/decompress.go # zstd/bytereader.go
Remove extra bounds check.
davecheney
reviewed
Jun 3, 2020
~1% faster ``` benchmark old MB/s new MB/s speedup BenchmarkDecompress4XNoTable/digits-32 539.58 539.10 1.00x BenchmarkDecompress4XNoTable/gettysburg-32 599.42 602.45 1.01x BenchmarkDecompress4XNoTable/twain-32 494.24 492.16 1.00x BenchmarkDecompress4XNoTable/low-ent.10k-32 721.10 723.53 1.00x BenchmarkDecompress4XNoTable/superlow-ent-10k-32 693.80 697.17 1.00x BenchmarkDecompress4XNoTable/case1-32 214.86 217.89 1.01x BenchmarkDecompress4XNoTable/case2-32 216.82 221.86 1.02x BenchmarkDecompress4XNoTable/case3-32 217.85 223.18 1.02x BenchmarkDecompress4XNoTable/pngdata.001-32 709.13 711.84 1.00x BenchmarkDecompress4XNoTable/normcount2-32 231.85 238.10 1.03x BenchmarkDecompress4XTable/digits-32 535.73 537.17 1.00x BenchmarkDecompress4XTable/gettysburg-32 418.03 420.13 1.01x BenchmarkDecompress4XTable/twain-32 492.16 494.24 1.00x BenchmarkDecompress4XTable/low-ent.10k-32 711.49 715.16 1.01x BenchmarkDecompress4XTable/superlow-ent-10k-32 670.99 673.28 1.00x BenchmarkDecompress4XTable/case1-32 28.75 28.90 1.01x BenchmarkDecompress4XTable/case2-32 24.69 24.61 1.00x BenchmarkDecompress4XTable/case3-32 26.02 25.95 1.00x BenchmarkDecompress4XTable/pngdata.001-32 685.85 689.59 1.01x BenchmarkDecompress4XTable/normcount2-32 65.53 66.29 1.01x ```
``` benchmark old ns/op new ns/op delta BenchmarkDecompress1XTable/digits-32 438004 436984 -0.23% BenchmarkDecompress1XTable/gettysburg-32 7610 7594 -0.21% BenchmarkDecompress1XTable/twain-32 1238883 1233712 -0.42% BenchmarkDecompress1XTable/low-ent.10k-32 161110 161066 -0.03% BenchmarkDecompress1XTable/superlow-ent-10k-32 42624 42459 -0.39% BenchmarkDecompress1XTable/crash2-32 636 626 -1.57% BenchmarkDecompress1XTable/endzerobits-32 78.0 70.8 -9.23% BenchmarkDecompress1XTable/endnonzero-32 438 426 -2.74% BenchmarkDecompress1XTable/case1-32 1911 1878 -1.73% BenchmarkDecompress1XTable/case2-32 1845 1834 -0.60% BenchmarkDecompress1XTable/case3-32 1860 1848 -0.65% BenchmarkDecompress1XTable/pngdata.001-32 209872 209872 +0.00% BenchmarkDecompress1XTable/normcount2-32 1330 1322 -0.60% BenchmarkDecompress1XNoTable/digits-32 437276 436904 -0.09% BenchmarkDecompress1XNoTable/gettysburg-32 6572 6550 -0.33% BenchmarkDecompress1XNoTable/twain-32 1235781 1231793 -0.32% BenchmarkDecompress1XNoTable/low-ent.10k-32 160400 160666 +0.17% BenchmarkDecompress1XNoTable/superlow-ent-10k-32 42090 42067 -0.05% BenchmarkDecompress1XNoTable/crash2-32 89.4 85.4 -4.47% BenchmarkDecompress1XNoTable/endzerobits-32 44.9 42.8 -4.68% BenchmarkDecompress1XNoTable/endnonzero-32 53.2 51.3 -3.57% BenchmarkDecompress1XNoTable/case1-32 252 247 -1.98% BenchmarkDecompress1XNoTable/case2-32 213 202 -5.16% BenchmarkDecompress1XNoTable/case3-32 225 222 -1.33% BenchmarkDecompress1XNoTable/pngdata.001-32 207247 207004 -0.12% BenchmarkDecompress1XNoTable/normcount2-32 384 383 -0.26% ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single threaded:
huff0 alone: