Add an efficient implementation of shard counts up to 65536 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff! I will take a look tomorrow. |
odeke-em
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Nice work @elias-orijtech and thank you! Just some initial nits, please take a look.
klauspost
reviewed
Jul 7, 2022
klauspost
requested changes
Jul 7, 2022
elias-orijtech
force-pushed
the
master
branch
7 times, most recently
from
4931acb to
0fdeedf
Compare
This is a O(n*log n) implementation of Reed-Solomon codes, ported from the C++ library https://github.com/catid/leopard. The implementation is based on the paper "Novel Polynomial Basis with Fast Fourier Transform and Its Application to Reed-Solomon Erasure Codes" Several TODOs are left for future commits: - Performance optimizations, in particular SIMD and multiple goroutines - Streaming methods - Merging of reedSolomonFF16 and reedSolomon types - Turn the straight C++ port into more idiomatic Go This change also bumps one race testing timeout, to ensure adequate time on CI.
klauspost
approved these changes
Jul 11, 2022
odeke-em
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Thank you, well done and LGTM @elias-orijtech! Thank you for the review @klauspost and the ball is in your court, please help with a merge!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a O(n*log n) implementation of Reed-Solomon
codes, ported from the C++ library https://github.com/catid/leopard.
The implementation is based on the paper
"Novel Polynomial Basis with Fast Fourier Transform
and Its Application to Reed-Solomon Erasure Codes"
Several TODOs are left for future commits:
CC @odeke-em