Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umlauts are very small on FP2 #535

Closed
Tuffiglig opened this issue Dec 27, 2016 · 23 comments
Closed

Umlauts are very small on FP2 #535

Tuffiglig opened this issue Dec 27, 2016 · 23 comments
Labels

Comments

@Tuffiglig
Copy link

Hallo.
The Umlauts are very small and hard to tip on my Fairphone 2 with the OS Fairphone Open 16.11.0 Android 5.1
Shown here in the Screenshot:
tmp_12830-screenshot_2016-12-27-13-50-21-1778267992

I didn't found a setting to change the size. Is there any?

Best regars,
Tuffi

@tohateam
Copy link

Press the Shift key and long press to enter the alternate characters.

@Tuffiglig
Copy link
Author

Sorry. I was to unclear :-(
How I get the Upper letters, I know.
My Problem is: With the new phone, the alternate characters are very, very small. It is very hard to press them, because they are too small.
With the old phone, they where as large as the normal characters.
I hope i was a little bit more clear this time.

@mase76
Copy link

mase76 commented Jan 1, 2017

I have the same problem on my FP2. I used the same version of HK on my last device with Cyanogenmod without problems.

@Herzfinsternis
Copy link

Same problem with Lineage OS 14.1 on ZUK Z1 (ham). I used the same version of Hackers Keyboard with Cyanogenmod 13 without that issue.
Even though this seems to be affected by the OS (unfortunately fiddling with display settings didn't help), I think that it would be reasonable to make the popup keys the same size as the keyboard keys. It is not only the characters, that are too small, but the keys themselves.

I was not able to take a screenshot when such a key has the focus, so you could see the size of the keys. :-(

hackers_keyboard_popup_keys_too_small

@TPS
Copy link
Contributor

TPS commented Mar 18, 2017

Have y'all tried fiddling w/ Settings » Theme and Label Settings > Key Label Scaling?

@Herzfinsternis
Copy link

I did so. But it is not the suggestions we are talking about. This is about the popup-keyboard, that shows when you long-press a key (key with letter a for example: 🅰). The popup-keyboard is not affected by that setting. The "Key label scaling" does affect that keyboard too, but that is no satisfiable solution to me.

@TPS
Copy link
Contributor

TPS commented Mar 18, 2017

That's right, @Herzfinsternis, I was mistaken. I fixed it above.

That's odd! I just realized that in your screenshot, your pop-up keyboard font-size is much smaller than the key font-size. Maybe it has to w/ y'all using Android alternatives? HK is built on very old Gingerbread (Android 2.3.×) code & maybe they don't support that version correctly? Or did an older version of HK work correctly for y'all?

@Herzfinsternis
Copy link

Herzfinsternis commented Mar 20, 2017

To me it seems as if Android 7.1 caused the problem, as I did not have problems with Android 6.0 and Hackers Keyboard and I know Google did change a few things related to display settings. On the other hand Tuffiglig uses Android 5.1.
I will try to test Hackers Keyboard with Android Studio emulator. I am new to android development. So this might take a while...
Eventually I will also try an older version of HK.

Update #1: On the emulator everything is fine

Update #2: Same issue with v1.38.2

@Tuffiglig
Copy link
Author

On my company phone Motorola Mot G4 Plus with Android 7.0, HK is working correctly.
TPS mentioned, that HK is build on a very old codebase. Is it possible to build it on a newer one and test it?

@Herzfinsternis
Copy link

A few odd observations:

Is it possible to enable the debug log for HK? Where would I find it on my phone?

@TPS
Copy link
Contributor

TPS commented Mar 20, 2017

@Tuffiglig: Rebuilding on a newer version of what's now GBoard would be almost-complete rewrite, & worthy of a major version increment. (Good luck! 🍀) As @klausw explains (in same link above) re: a lot of new feature requests (& some bugs):

… is not supported and is not going to be - the underlying Gingerbread AOSP keyboard that the code is based on doesn't support it, and it's not really feasible to backport this. I think it would be easier to start fresh with a more current upstream AOSP keyboard and port the layouts and other features over, but I don't have any plans to do so.

@Herzfinsternis I've no idea whether debug logs are even possible via UI. Maybe @klausw, @dsalt, @sbeyer, @Poussinou, or really active dev could help out?

@Herzfinsternis
Copy link

Herzfinsternis commented Mar 20, 2017

I managed to debug HK on my device and in emulator.

public Keyboard(Context context, int defaultHeight, int xmlLayoutResId, int modeId, float kbHeightPercent) {
DisplayMetrics dm = context.getResources().getDisplayMetrics();

Device:
DisplayMetrics{density=3.0, width=1080, height=1920, scaledDensity=3.0, xdpi=160.421, ydpi=159.895}

Emulator:
DisplayMetrics{density=2.5, width=1080, height=1800, scaledDensity=2.5, xdpi=400.0, ydpi=400.0}

This seems to be a problem with (and originating from) LineageOS build for ZUK Z1 (ham). Any ideas what files/values need to be edited to correct the display metrics?
https://github.com/LineageOS/android_device_zuk_ham
As mentioned before, I am not an android developer. So any hint would be great. Otherwise I would have to explain everything again over at LineageOS.

@TPS
Copy link
Contributor

TPS commented Mar 20, 2017

@Herzfinsternis Most devs are very amenable to reading a linked issue, so unlikely you'd have to explain much. Try them & see.

@Herzfinsternis
Copy link

No update from LineageOS developers yet. But I found out that both devices (Fairphone2, ZUK Z1) are run on Snapdragon 801 (MSM8974). Maybe that's the source of the problem.

@TPS
Copy link
Contributor

TPS commented Apr 3, 2017

@Herzfinsternis My best hunch is it probably has nothing really to do w/ hardware nor OS version per sé, but everything to w/ LineageOS v7's support for apps written for Android v2, as, I'm sure, almost any stock Android (or close enough equivalent) from 2.3.× through 7.1.1 (on much of which I've run HK) on almost all hardware does handle it just fine. Do keep us updated w/ whatever the L-OS devs say.

@klausw
Copy link
Owner

klausw commented Apr 3, 2017

@Herzfinsternis wrote:

Device:
DisplayMetrics{density=3.0, width=1080, height=1920, scaledDensity=3.0, xdpi=160.421, ydpi=159.895}

Emulator:
DisplayMetrics{density=2.5, width=1080, height=1800, scaledDensity=2.5, xdpi=400.0, ydpi=400.0}

I think that's the problem right there - the device reports a 1920x1080 resolution with 160 dpi, so that means it claims a screen size of 12 inches by 6.7 inches. The GUI will draw characters so that they are scaled appropriately for that screen size, but if the actual device is phone-sized they'll end up way too small.

@TPS
Copy link
Contributor

TPS commented Apr 4, 2017

@klausw Any reason then that the Key Labels are scaled differently than the pop-up?

@klausw
Copy link
Owner

klausw commented Apr 5, 2017

@TPS Yes, the difference is that key labels use a rather complicated method to pick a label size. For the pop-up, I'm expecting the operating system to do the right thing. Honestly I'm not too motivated to fix this, if the vendor decides to report their phone as having a laptop-sized screen they should fix that, it'll also break other content.

@Herzfinsternis
Copy link

I too think that should be fixed by the "vendor". Fairphone Open and Lineage OS are both open source. I believe it should be possible to fix that somehow. Unfortunately there is no progress so far. Perhaps I will find someone on XDA who can help me or push me in the right direction.

@TPS
Copy link
Contributor

TPS commented Apr 5, 2017

@Tuffiglig I found similar bug report as @Herzfinsternis's, but w/ FairPhone, so this is a known issue FIXED in latest OS version, not a problem w/ HK.

https://forum.fairphone.com/t/google-cardboard-screen-scale-issue-might-be-fp2-reports-wrong-dpi/11706/38

Mark Closed/Invalid FTW?

@klausw klausw added the wontfix label Apr 5, 2017
@klausw
Copy link
Owner

klausw commented Apr 5, 2017

@TPS thanks for digging that up. Cardboard actually has a database of misconfigured devices since this was a rather common problem, but most mismatches weren't this bad.

@klausw klausw closed this as completed Apr 5, 2017
@Tuffiglig
Copy link
Author

For the Fairphone the Problem was fixed in Version Fairphone Open OS 17.02
I switched to AnyKeyboard in the meantime, because this bug was very annoying, and didn't realised that it was fixed.
On my device it works correct now. Time to deinstall AnyKeyboard :)
photo5415903200357230524

@Herzfinsternis
Copy link

Problem solved!

After updating /system/build.prop (adding the line qemu.sf.lcd_density=480 after ro.sf.lcd_density=480) everything works as expected.

I am so very happy! Thanks to all of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants