Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

define Default zero address #190

Merged
merged 3 commits into from
Dec 11, 2020
Merged

define Default zero address #190

merged 3 commits into from
Dec 11, 2020

Conversation

sirano11
Copy link

Proposed changes

This PR changes the default value of the address from 0x to 0x0000000000000000000000000000000000000000 in 20 bytes. Since Klaytn's address has a fixed length of 20 bytes, it cannot have 0x as a default.

  • Define default zero address in caver.utils. : DEFAULT_ZERO_ADDRESS
  • from, fee payer field in Transaction set default value as 0x0000000000000000000000000000000000000000

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@sirano11 sirano11 requested a review from jimni1222 December 11, 2020 01:53
@sirano11 sirano11 self-assigned this Dec 11, 2020
@sirano11 sirano11 requested a review from kjhman21 as a code owner December 11, 2020 01:53
Copy link
Contributor

@jimni1222 jimni1222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thank you for changing!

@sirano11 sirano11 merged commit be6a6e2 into klaytn:dev Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants