This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Implemented functions for extract signatures and split fee payer #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces new functions in makeRawTransaciton.js file named 'extractSignatures' and 'splitFeePayer'.
extractSignatures function extracts signatures and feePayerSignatures from rawTransaction.
splitFeePayer function deocde rawTransaction and make fee payer tx format.
And also deocdeRawTransaction function is modified to call _decodeFromRawTransaction.
Because when combine raw transaction string(not included in this PR), transaction have to compare with other transaction string.
For easier comparison, _decodeFromRawTransaction returns string format of accountKey without parsing.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
refer #117
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...