Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Implemented functions for extract signatures and split fee payer #125

Merged
merged 4 commits into from
Oct 16, 2019

Conversation

jimni1222
Copy link
Contributor

@jimni1222 jimni1222 commented Oct 15, 2019

Proposed changes

This PR introduces new functions in makeRawTransaciton.js file named 'extractSignatures' and 'splitFeePayer'.

extractSignatures function extracts signatures and feePayerSignatures from rawTransaction.
splitFeePayer function deocde rawTransaction and make fee payer tx format.

And also deocdeRawTransaction function is modified to call _decodeFromRawTransaction.
Because when combine raw transaction string(not included in this PR), transaction have to compare with other transaction string.
For easier comparison, _decodeFromRawTransaction returns string format of accountKey without parsing.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

refer #117

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 self-assigned this Oct 15, 2019
@jimni1222 jimni1222 changed the title Implemented functions for extract signatures and make fee payer format Implemented functions for extract signatures and split fee payer Oct 16, 2019
@jimni1222 jimni1222 merged commit 47bf713 into klaytn:dev Oct 16, 2019
@jimni1222 jimni1222 deleted the decodeTx branch October 16, 2019 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants