Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Modified signTransaction logic and implemented feePayerSignTransaction #130

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR introduces modification signing logic and newly implemented functions.

  1. signTransaction is modified for handling RLP encoded raw transaction and appending.

  2. feePayerSignTransaction is implemented for fee payer.

  3. signTransaction and feePayerSignTransaction function remove duplication of signatures.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

refer #117

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 self-assigned this Oct 18, 2019
@jimni1222 jimni1222 merged commit 8d86324 into klaytn:dev Oct 18, 2019
@jimni1222 jimni1222 deleted the implAccountKey branch October 18, 2019 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants