Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Implemented getRawTransactionWithSignatures and combineSignatures #132

Merged
merged 7 commits into from
Oct 20, 2019

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR introduces getRawTransactionWithSignatures and combineSignatures functions.

  1. getRawTransactionWithSignatures
    : This function is a change from the existing signTransactionWithSignature function.
    Creates an RLP encoded transaction, taking as a parameter a transaction object containing signatures or feePayerSignatures.

  2. combineSignatures
    : The combineSignatures function combines multiple RLP encoded transactions into a single RLP encoded transaction.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

refer #117

Further comments

Remain PR contents

  1. sendSignedTransaction
  2. test codes

@jimni1222 jimni1222 self-assigned this Oct 18, 2019
Co-Authored-By: Junghyun Colin Kim <Colin.kim@groundx.xyz>
@jimni1222 jimni1222 merged commit f0023b6 into klaytn:dev Oct 20, 2019
@jimni1222 jimni1222 deleted the implAccountKey branch October 20, 2019 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants