This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Use setRequestManager instead of setProvider for adding data listener once only #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR includes the implementation of the setRequestManager function to prevent the addition of multiple data listeners.
This bug is caused by calling the setProvider function for each package when an instance is created.
Calling setProvider for each package adds a data listener to each provider internally.
Old Behaviour
New Behaviour
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
close #230
Further comments
This PR reflected the changes in web3/web3.js#3156
PR.
The changes in above PR are included at other PR, but the other PR has many other changes.
So this PR reflected only the changes in web3/web3.js#3156
Also i included web3/web3.js@26a8775 to change Contract instance's provider when caver.klay.setProvider is called.
After this PR is merged, caver-js v1.4.0-rc.1 will be published.