Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Added validation logic in utils and isEqual function in SignatureData #520

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

jimni1222
Copy link
Contributor

Proposed changes

This PR introduces adding some validation logic to test with conformance TC.

And the reason for deleting the line if (_.isObject(unitString) && unitString.unit) unitString = unitString.unit is that the convertToPeb and convertFromPeb functions call the toPeb and fromPeb functions.
Since each function calls getKlayUnitValue internally, duplicate logic was removed by adding validation logic to getKlayUnitValue and changing it to be verified together.

And also i added isEqual function in SignatureData to compare signature easily.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 requested a review from aeharvlee as a code owner August 17, 2021 07:45
@jimni1222 jimni1222 self-assigned this Aug 17, 2021
@jimni1222 jimni1222 merged commit a417909 into klaytn:dev Aug 17, 2021
@jimni1222 jimni1222 deleted the conformance branch August 17, 2021 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants