Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Fix hexToNumber and hexToNumberString prefix validation #564

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

securekim
Copy link
Contributor

@securekim securekim commented Dec 23, 2021

  • Bugfix
  • Allow compatibility
  • Modify tests

Proposed changes

  • Throw error when argument of hexToNumber and hexToNumberString is not prefixed with 0x.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

  • Edit package.json for lint on windows

"lint": "./node_modules/.bin/eslint --ext .js .",
"lintFix": "./node_modules/.bin/eslint --fix --ext .js .",

* Bugfix
* Allow compatibility
* Modify tests
@aeharvlee
Copy link
Contributor

aeharvlee commented Dec 24, 2021

Thanks for your PR 😄
It looks great to me, but main dev of caver-js should review this PR.
Thanks for your patience :)

cc. @jimni1222

Copy link
Contributor

@jimni1222 jimni1222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM =) Thank you for contribution!

@jimni1222 jimni1222 merged commit 3ad8dc2 into klaytn:dev Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants