-
Notifications
You must be signed in to change notification settings - Fork 75
Add CurrentProvider Type Definition in index.d.ts #710
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@godtaehee Thank you for contribution. Please sign CLA. #710 (comment) |
@godtaehee Could you please also add a simple test case to check whether this is accessible from the client code? |
Thanks, I just signed to CLA I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for contribution!!
After resolving @kjhman21 comment, we can merge this and release :)
Sure, sir. I will make some test case, and push it! |
I think you need to write |
I have read the CLA Document and I hereby sign the CLA |
@kjhman21 I just made test code in I can use currentProvider when I use it in js environment using require like my repository code So I think there is no need for testing in js file which is located in I searched all of test code in repository. but I can't find the location where I test it. So If this my Sorry for not well in contributing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thanks :D I will nestjs-caver which can be interacted with nest.js and caver! |
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
I wrote all of my issue in this issue
and this is my repository which prove my inconvenient about caver.js
Thanks.
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...