Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

validateSignedMessage bug fix when signed in Korean message #730

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

nohkwak
Copy link
Member

@nohkwak nohkwak commented Dec 20, 2022

Proposed changes

  • When Korean text message is signed, the signature is not properly verified with the validateSignedMessage function.
  • Add logic to change encoding with utf8ToHex function if it is not Hex encoding.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

  • none

@nohkwak nohkwak merged commit ee29459 into klaytn:dev Dec 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants