Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Update ChainConfig API #741

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Update ChainConfig API #741

merged 6 commits into from
Mar 16, 2023

Conversation

nohkwak
Copy link
Member

@nohkwak nohkwak commented Mar 13, 2023

Proposed changes

  • chainConfig related update for version 1.10.2

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • none

Further comments

  • none

@nohkwak
Copy link
Member Author

nohkwak commented Mar 13, 2023

@ian0371
'klay_getChainConfig' is deployed?
I ask to confirm that klay_getChainConfig has not been applied yet.

image

@ian0371
Copy link

ian0371 commented Mar 13, 2023 •
edited
Loading

@nohkwak As in the table, klay_getChainConfig will exist from v1.10.2. If you're asking if v1.10.2 has been deployed to baobab/cypress, no they are not yet. Baobab is running on v1.10.1 and cypress on v1.9.1

@ian0371
Copy link

ian0371 commented Mar 16, 2023 •
edited
Loading

@nohkwak I updated the table to look like this (also for klay_) to reduce confusion. PR does not need to change.

image

@nohkwak nohkwak requested a review from kjeom March 16, 2023 11:08
@nohkwak nohkwak merged commit 5808132 into klaytn:dev Mar 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 left review comments

@kjeom kjeom kjeom approved these changes

@jimni1222 jimni1222 Awaiting requested review from jimni1222

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@kjhman21 kjhman21 Awaiting requested review from kjhman21 kjhman21 is a code owner

Assignees

@nohkwak nohkwak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nohkwak @ian0371 @kjeom