This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacscoding
requested review from
aidan-kwon,
jimni1222,
sirano11,
aeharvlee,
JayChoi1736,
henry-will,
nohkwak and
2dvorak
as code owners
June 22, 2022 12:21
hyunsooda
reviewed
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good change.
hyunsooda
reviewed
Jul 12, 2022
hyunsooda
reviewed
Jul 18, 2022
hyunsooda
previously approved these changes
Jul 19, 2022
yoomee1313
requested review from
kjeom and
ian0371
and removed request for
sirano11,
aeharvlee,
JayChoi1736 and
2dvorak
December 27, 2022 08:32
yoomee1313
reviewed
Mar 21, 2023
As ethereum has already implemented it, i will close this PR :( |
You have successfully added a new CodeQL configuration |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
Although console is the useful interactive cli tools, we could not request to external api services such as KAS.
Now we can use console cli for external apis like below