Added fix to hasOne relationship #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
What was the previous problem you faced with hasOne relationships? I'm trying to understand why you changed the search of hasMany to hasOne |
|
I believe the author may have made a copy-paste error, in the definitions for one to one relationships it looks like code was pasted from the many to many relationship instead. Also, it was missing the 'new' keyword... Basically, one to one relationships cannot work at all with the current code, but do work with the changes I've suggested. I recommend you test them out to make sure, and there might be a simpler solution but this one works as far as I know,. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a fix and a couple of simplifications to the way ModelCore handles relationships. Hope this helps!