Test: Fix Error on Null Title

See: https://mantis.ilias.de/view.php?id=43627
klees · Jan 15, 2025 · 3287444 · 3287444
1 parent daa81df
commit 3287444
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/components/ILIAS/Test/classes/Evaluation/class.ilTestEvaluationFactory.php b/components/ILIAS/Test/classes/Evaluation/class.ilTestEvaluationFactory.php
@@ -110,7 +110,7 @@ public function getEvaluationData(): ilTestEvaluationData
                 $user_eval_data = new ilTestEvaluationUserData($scoring_settings);
 
                 $user_eval_data->setName(
-                    $this->test_obj->buildName($row['usr_id'], $row['firstname'], $row['lastname'], $row['title'])
+                    $this->test_obj->buildName($row['usr_id'], $row['firstname'], $row['lastname'], $row['title'] ?? '')
                 );
 
                 if ($row['login'] !== null) {

diff --git a/components/ILIAS/Test/classes/class.ilObjTest.php b/components/ILIAS/Test/classes/class.ilObjTest.php
@@ -2553,19 +2553,23 @@ public function getCompleteEvaluationData($filterby = '', $filtertext = ''): ilT
     * @return string The output name of the user
     * @access public
     */
-    public function buildName($user_id, $firstname, $lastname, $title): string
-    {
+    public function buildName(
+        int $user_id,
+        string $firstname,
+        string $lastname,
+        string $title
+    ): string {
         $name = "";
-        if (strlen($firstname . $lastname . $title) == 0) {
+        if ($firstname . $lastname . $title !== '') {
             $name = $this->lng->txt('deleted_user');
         } else {
             if ($user_id == ANONYMOUS_USER_ID) {
                 $name = $lastname;
             } else {
-                $name = trim($lastname . ", " . $firstname . " " . $title);
+                $name = trim($lastname . ', ' . $firstname . ' ' . $title);
             }
             if ($this->getAnonymity()) {
-                $name = $this->lng->txt("anonymous");
+                $name = $this->lng->txt('anonymous');
             }
         }
         return $name;