Add support for params[:env] (that is, the env kwarg to the addprocs() function)
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/params-env
branch
3 times, most recently
from
973dcd0 to
4eb6a50
Compare
DilumAluthge
changed the title
params[:env]params[:env] (that is, the env kwarg to the addprocs() function)
DilumAluthge
force-pushed
the
dpa/params-env
branch
2 times, most recently
from
5f4e800 to
5614ff7
Compare
This was referenced Dec 31, 2024
|
Okay, I think this is ready for review @kleinhenz. cc: @jbphyswx - in this PR, I just focused on implementing only the first piece, namely support for |
DilumAluthge
force-pushed
the
dpa/params-env
branch
from
5614ff7 to
81e6d4c
Compare
…rocs()` function) Co-authored-by: jbphyswx <jbenjami@caltech.edu>
DilumAluthge
force-pushed
the
dpa/params-env
branch
from
81e6d4c to
5ba8364
Compare
|
Could this be merged? We need this for using SlurmManager in PySR as the new distributed backend. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Pre-requisite for #19.
Pre-requisite for #30.