fix(#14) Add missing operational status for other heat pumps

klejejs · Jan 2, 2023 · 65d32fc · 65d32fc
1 parent 094561a
commit 65d32fc
Show file tree

Hide file tree

Showing 4 changed files with 128 additions and 63 deletions.
diff --git a/ThermiaOnlineAPI/api/ThermiaAPI.py b/ThermiaOnlineAPI/api/ThermiaAPI.py
@@ -5,7 +5,7 @@
 from requests import cookies
 import json
 import hashlib
-from typing import Dict, Union
+from typing import Dict, Optional
 
 from ThermiaOnlineAPI.const import (
     REG_GROUP_HOT_WATER,
@@ -295,9 +295,7 @@ def __get_switch_register_index_and_value_from_group_by_register_name(
             "registerValue": int(register_value),
         }
 
-    def get_group_hot_water(
-        self, device: ThermiaHeatPump
-    ) -> Dict[str, Union[int, None]]:
+    def get_group_hot_water(self, device: ThermiaHeatPump) -> Dict[str, Optional[int]]:
         register_data: list = self.__get_register_group(device.id, REG_GROUP_HOT_WATER)
 
         hot_water_switch_data = (
@@ -462,7 +460,7 @@ def __fetch_configuration(self):
 
         return request.json()
 
-    def __authenticate_refresh_token(self) -> Union[str, None]:
+    def __authenticate_refresh_token(self) -> Optional[str]:
         request_token__data = {
             "client_id": THERMIA_AZURE_AUTH_CLIENT_ID_AND_SCOPE,
             "redirect_uri": THERMIA_AZURE_AUTH_REDIRECT_URI,

diff --git a/ThermiaOnlineAPI/const.py b/ThermiaOnlineAPI/const.py
@@ -75,8 +75,15 @@
 # Operational status registers
 ###############################################################################
 
-REG_OPERATIONAL_STATUS_PRIO1 = "REG_OPERATIONAL_STATUS_PRIO1"
+REG_OPERATIONAL_STATUS_PRIO1 = (
+    "REG_OPERATIONAL_STATUS_PRIO1"  # Operational status for most heat pumps
+)
+COMP_STATUS_ITEC = "COMP_STATUS_ITEC"  # Operational status for ITEC heat pumps
+REG_OPERATIONAL_STATUS_PRIORITY_BITMASK = (
+    "REG_OPERATIONAL_STATUS_PRIORITY_BITMASK"  # Operational status for Atlas heat pumps
+)
 REG_INTEGRAL_LSD = "REG_INTEGRAL_LSD"
+REG_PID = "REG_PID"
 
 ###############################################################################
 # Hot water registers