Skip to content

feat(web): add-toast-for-graph-and-rpc-errors #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 2, 2024
Merged

feat(web): add-toast-for-graph-and-rpc-errors #1466

merged 6 commits into from
Feb 2, 2024

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Jan 30, 2024 •
edited by pr-codex bot
Loading

  • Adds a debounced toast to show whenever there is an RPC error (in useDisputeTemplate) or Graph Error (Global)

PR-Codex overview

Detailed summary

  • Added RPC_ERROR constant to handle RPC error messages.
  • Added debounceErrorToast function to display error messages with a debounce effect.
  • Updated components and hooks to handle and display RPC errors appropriately.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

This was linked to issues Jan 31, 2024
Web: Toastify the errors from the Graph and RPC #1453
Closed
Web: don't show that easily the message "dispute template not correct, please vote refuse to arbitrate" #1459
Closed
@tractorss tractorss marked this pull request as ready for review January 31, 2024 08:21
alcercu
alcercu reviewed Jan 31, 2024
View reviewed changes
alcercu
alcercu previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added Package: Web Court web frontend Type: UX User Experience labels Feb 2, 2024
@tractorss tractorss changed the base branch from fix(web)/use-dispute-template-fix to dev February 2, 2024 09:44
@tractorss tractorss dismissed alcercu’s stale review February 2, 2024 09:44

The base branch was changed.

@tractorss tractorss requested a review from alcercu February 2, 2024 09:45
alcercu
alcercu approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu enabled auto-merge February 2, 2024 10:22
@netlify Netlify
Copy link

netlify bot commented Feb 2, 2024 •
edited
Loading

❌ Deploy Preview for kleros-v2 failed.

Name Link
🔨 Latest commit 4e32c41
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65bcc820cb04da0008836c5a

@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 2, 2024

Code Climate has analyzed commit 4e32c41 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alcercu alcercu added this pull request to the merge queue Feb 2, 2024
Merged via the queue into dev with commit 524cc8b Feb 2, 2024
@jaybuidl jaybuidl deleted the feat(web)/graph-and-rpc-error-toasts branch October 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: UX User Experience
Projects
None yet
Milestone
No milestone
2 participants
@tractorss @alcercu