-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KC): phases implementation #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely more on inputs from view functions to pass the phases. Removal of the active dispute kits state in KlerosCore. Allow changing the dispute kit phase from Drawing to Resolving inside DK.passPhase(). For safety, DK.passPhase() can reset its phase if it ever is not Resolving when Core is Staking. Disabled the contract size limit on the Hardhat network because it's not a limitation on Arbitrum.
Also less reliance on the bots, clearer function names.
…g a DK back to Resolving And fixed an array element removal.
Code Climate has analyzed commit a7d325f and detected 0 issues on this pull request. View more on Code Climate. |
unknownunknown1
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR for this :)
Resolves #26
Duplicates #64 #42