feat: Initial web app for the court #69
Conversation
|
I think we should have the file organisation as simple as is convenient. If a component is used multiple times by all means it should be in a separate file. But in case of a component with <50 lines which will be used only once I don't see why it should be in a separate file. It only makes the directory tree more complex and navigating between components harder. This applies to the header and footer related components. I would even say that the layout, header and footer components should be one file. |
|
Thanks for the refactor @AndreiMVP! Regarding the file organization, I prefer to keep it in separated files even if these components are used once and only in the context of the layout. This is mainly because they might be small now, but once we start adding the desktop styling they might grow. Also, I think it's better to keep them abstracted, so in the future, if someone wants to modify some part of the layout, not related to the header and footer, they can focus directly on the part that matters. |
jaybuidl
changed the title
|
Let's try merge this branch and continue working in a new more specific one, maybe |
|
@jaybuidl @AndreiMVP I think this is ready to be merged, the last codeclimate duplication issues are in the theme file and in a file (LatestCases) that it's not fetching data yet (so the duplication comes from the manually-inserted data). There are issues regarding some type exporting, I think this is due to the difference between tslint (deprecated) and eslint with typescript support (the one we use locally), we need to look into updating codeclimate's linter. |
|
Code Climate has analyzed commit d145e28 and detected 123 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
Feat: Initial web app for the court
No description provided.