refactor(cms):r-and-d-types

[tractorss]

Summary by CodeRabbit

• New Features

  • Added a new waitlistSection attribute to the R&D Page Fellowship Tab Section
  • Simplified naming for the Waitlist Section component

• Refactor

  • Removed separate API endpoints for Fellowship Waitlist Section
  • Updated display names and attribute naming conventions for Research and Third-Party Publication schemas

• Style

  • Adjusted capitalization and naming conventions across various schemas

[coderabbitai]

Walkthrough

This pull request involves modifications to the CMS backend, primarily focusing on the R&D page fellowship section. The changes include adding a new waitlistSection attribute to the fellowship tab section schema, removing the fellowship waitlist section API components, updating the display names and naming conventions for various schemas, and simplifying the waitlist section component configuration.

Changes

File	Change Summary
cms-backend/src/api/r-and-d-page-fellowship-tab-section/schema.json	Added new waitlistSection component attribute
cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/*	Removed controller, routes, and services files
cms-backend/src/api/research/content-types/research/schema.json	Updated display name capitalization from "research" to "Research"
cms-backend/src/api/third-party-publication/schema.json	Changed attribute name from "Topic" to "topic"
cms-backend/src/components/r-and-d-page/waitlist-section.json	Renamed collection, simplified display name, removed draft/publish options

Suggested reviewers

• alcercu

Possibly related PRs

• Feat/r and d page types #44: Modifications to the r-and-d-page-fellowship-tab-section schema

Poem

🐰 A Rabbit's CMS Rhyme 🔧

In schemas and routes, changes unfurl,
Waitlist sections dance, components twirl
Naming conventions, now sleek and bright
CodeRabbit's magic takes playful flight!

hop hop 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bf35db and b347557.

⛔ Files ignored due to path filters (2)

• cms-backend/types/generated/components.d.ts is excluded by !**/generated/**
• cms-backend/types/generated/contentTypes.d.ts is excluded by !**/generated/**

📒 Files selected for processing (7)

• cms-backend/src/api/r-and-d-page-fellowship-tab-section/content-types/r-and-d-page-fellowship-tab-section/schema.json (1 hunks)
• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/controllers/r-and-d-page-fellowship-waitlist-section.ts (0 hunks)
• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/routes/r-and-d-page-fellowship-waitlist-section.ts (0 hunks)
• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/services/r-and-d-page-fellowship-waitlist-section.ts (0 hunks)
• cms-backend/src/api/research/content-types/research/schema.json (1 hunks)
• cms-backend/src/api/third-party-publication/content-types/third-party-publication/schema.json (1 hunks)
• cms-backend/src/components/r-and-d-page/waitlist-section.json (1 hunks)

💤 Files with no reviewable changes (3)

• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/controllers/r-and-d-page-fellowship-waitlist-section.ts
• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/routes/r-and-d-page-fellowship-waitlist-section.ts
• cms-backend/src/api/r-and-d-page-fellowship-waitlist-section/services/r-and-d-page-fellowship-waitlist-section.ts

✅ Files skipped from review due to trivial changes (1)

• cms-backend/src/api/research/content-types/research/schema.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Redirect rules - kleros-website-v2
• GitHub Check: Header rules - kleros-website-v2
• GitHub Check: Pages changed - kleros-website-v2

🔇 Additional comments (3)

cms-backend/src/api/third-party-publication/content-types/third-party-publication/schema.json (1)

15-15: LGTM! Improved naming convention.

The change from "Topic" to "topic" aligns with JavaScript/JSON naming conventions (camelCase) and improves consistency across the codebase.

cms-backend/src/components/r-and-d-page/waitlist-section.json (1)

2-6: LGTM! Improved component configuration.

The changes improve the component structure by:

1. Using a more appropriate collection naming pattern for components
2. Simplifying the configuration by removing redundant fields
3. Removing unnecessary options that aren't typically needed for components

cms-backend/src/api/r-and-d-page-fellowship-tab-section/content-types/r-and-d-page-fellowship-tab-section/schema.json (1)

30-33: LGTM! Improved architecture by consolidating related functionality.

The integration of the waitlist section as a component within the fellowship tab section is a better architectural approach. It simplifies the API surface and keeps related functionality together.

Let's verify that the removal of separate API endpoints won't break existing functionality:

✅ Verification successful

✅ Verified: Component integration is complete and clean

The waitlist section has been properly integrated as a component with no lingering references to old API endpoints. The type system and schema definitions are consistent with the new structure.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any remaining references to the old API endpoints
rg -i "r-and-d-page-fellowship-waitlist-section" --type ts --type tsx --type json

Length of output: 109

---

Script:

#!/bin/bash
# Search for any references to the old waitlist section without file type restrictions
rg -i "waitlist.*section" 

# Also check for specific component references
rg -i "r-and-d-page\.waitlist"

# Look for any strapi related configuration or routes
fd "routes.json|schema.json" --exec grep -i "waitlist"

Length of output: 1687

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for kleros-website-v2 ready!

Name	Link
🔨 Latest commit	b347557
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-website-v2/deploys/6784fc11aaf77f0008c6b903
😎 Deploy Preview	https://deploy-preview-46--kleros-website-v2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alcercu]

lgtm