Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oci): Suppport ip for cmd #100

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Jul 28, 2020

What this PR does / why we need it:

When exec ormb save or other cmd, if use ip,there is an error as follow:

 ./bin/ormb save ./examples/SavedModel-fashion 192.168.22.160:30002/release/savedmodel:v1
Using config file: /Users/caicloud/.ormb/config.json
Using /Users/caicloud/.ormb as the root path
[192.168.22.160 30002/release/savedmodel v1]
components: [192.168.22.160:30002/release/savedmodel v1]
suc1
Error: parse 192.168.22.160:30002/release/savedmodel: first path segment in URL cannot contain colon
Usage:
  ormb save [flags]

Flags:
  -h, --help   help for save

Global Flags:
      --config string   config file (default is $HOME/.ormb/config.json)

parse 192.168.22.160:30002/release/savedmodel: first path segment in URL cannot contain colon

according to issue, resolve it by this PR

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2020
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@caicloud-bot caicloud-bot merged commit ea48a4c into kleveross:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants