Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation for ormb save command #106

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Aug 5, 2020

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #11

Reference to #

Special notes for your reviewer:

/cc @gaocegege

Release note:

NONE

@caicloud-bot caicloud-bot requested a review from gaocegege August 5, 2020 10:50
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2020
@simon-cj
Copy link
Contributor Author

simon-cj commented Aug 5, 2020

/retest

@simon-cj simon-cj force-pushed the add-validate-directory branch 2 times, most recently from 3bee1e5 to ad60bd6 Compare August 5, 2020 11:02
@simon-cj simon-cj changed the title feat: Add validation for ormb save command 【WIP】feat: Add validation for ormb save command Aug 5, 2020
@caicloud-bot caicloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2020
@simon-cj simon-cj force-pushed the add-validate-directory branch 11 times, most recently from a0587c9 to c7fea86 Compare August 6, 2020 06:29
@gaocegege
Copy link
Member

Please repush, I forgot to update the name.

@simon-cj simon-cj force-pushed the add-validate-directory branch from c7fea86 to 14b8f1a Compare August 6, 2020 06:37
@simon-cj simon-cj changed the title 【WIP】feat: Add validation for ormb save command feat: Add validation for ormb save command Aug 6, 2020
@caicloud-bot caicloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2020
@simon-cj
Copy link
Contributor Author

simon-cj commented Aug 6, 2020

/cc @gaocegege

@gaocegege
Copy link
Member

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@caicloud-bot caicloud-bot merged commit 49e9c89 into kleveross:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Validate model directory for the given format
3 participants