Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add default tag when tag is empty #113

Merged
merged 3 commits into from
Aug 12, 2020
Merged

chore: add default tag when tag is empty #113

merged 3 commits into from
Aug 12, 2020

Conversation

whalecold
Copy link
Contributor

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @gaocegege

Release note:

NONE

@caicloud-bot caicloud-bot requested a review from gaocegege August 11, 2020 15:11
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2020
@whalecold
Copy link
Contributor Author

docker will use latest tag when the provided tag is empty.
Uploading image.png…

gaocegege
gaocegege reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also need to support it in save and push.

@whalecold
Copy link
Contributor Author

Maybe we also need to support it in save and push.

Done, I moved it to the ParseReference function, that can unifies all kinds operator.

@caicloud-bot caicloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2020
gaocegege
gaocegege reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@caicloud-bot caicloud-bot merged commit 92adb22 into kleveross:master Aug 12, 2020
@whalecold whalecold deleted the tag branch June 13, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

Assignees

@gaocegege gaocegege

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whalecold @caicloud-bot @gaocegege