[python-sdk] Remove requests dependency #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested both locally and from the branch: pip install git+https://git@github.com/gbolmier/ormb.git@hotfix/python-sdk/remove-requests-dependency#subdirectory=extern-sdk/pythonworks as a charm on my side 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind dependency
What this PR does / why we need it:
It replaces
requestsdependency withurllib.requestfrom the python standard library ingit_release.py(called bysetup.py) in the python sdk. We need to get rid of therequestsdependency to fix thesetup.pybug that calls therequestspackage before installing it.Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #195
Special notes for your reviewer:
Does this PR introduce a user-facing change?: