Install locale data into nested locations; Pick files from /usr/(local/)share with sys.prefix #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
force-pushed
the
fix_locale_data
branch
2 times, most recently
from
f809812
to
7c2eb2e
Compare
hrnciar
reviewed
Aug 31, 2020
All *.mo files were copied directly to share/pronterface
hroncok
force-pushed
the
fix_locale_data
branch
from
7c2eb2e
to
77aa66f
Compare
hroncok
changed the title
kliment
reviewed
Sep 6, 2020
pronterface expects to find its images in sys.prefix/share/pronterface/images but setup.py places them in sys.prefix/share/pronterface, this should fix that
|
works correctly when installed in a venv now - @hroncok do you have any objections to me merging it as it is now? |
|
Ship it, thanks. |
|
I think this is a good time to do rc7 and try the pip-installed stuff out on various platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All *.mo files were copied directly to share/pronterface