Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pronterface pot file and german po file #1144

Merged
merged 5 commits into from
Jan 25, 2021
Merged

updated pronterface pot file and german po file #1144

merged 5 commits into from
Jan 25, 2021

Conversation

freddii
Copy link
Contributor

@freddii freddii commented Jan 21, 2021

No description provided.

#: printrun/gcview.py:352
#: printrun/gcview.py:106
msgid "Invalid layer for injection"
msgstr "Ungültiger Abschnitt angegeben"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the correct translation - Abschnitt is section rather than layer.

#, fuzzy
msgid "Plater"
msgstr "Heizelement"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not a correct translation - the plater is the part of the application that lets you arrange objects on the printing plate, whereas Heizelement means heater.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so do you know a good translation for plater?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really - best I can think of is "Zusammenstellung" but that's not quite the same thing. But "Heizelement" is definitely wrong so it's better to leave it untranslated if we can't figure out a better word.

msgid "Print start callback failed with:"
msgstr ""
msgstr "Druckstart-Rückmeldung fehlgeschlagen mit:"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use "Rückruffunktion" or "Rückruf" instead of "Rückmeldung" for "callback". I don't think it's clear what it means from the translation. Perhaps even use "Callback". This is referring to a user-provided function that is called when certain events happen.

msgid "Printer is not online. Unable to reverse."
msgstr "Drucker ist nicht online."
msgstr "Drucker ist nicht online. Rückgängigmachen nicht möglich."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse here means to drive the extruder motor in reverse so as to pull back the filament. I don't have a better suggestion for a translation that what you have, but I don't think it communicates that

msgid "Draw a circular (or oval) build platform instead of a rectangular one"
msgstr ""
"Zeichnen Sie eine kreisförmige (oder ovale) Plattform anstelle einer "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Zeichnet" instead of "Zeichnen Sie" - it describes what the program does, not what the user is meant to do

@kliment
Copy link
Owner

kliment commented Jan 25, 2021

@freddii Thank you for your translation! I've pointed out a few issues I see, but other than that it's great and I would love to merge it. Can you fix the problems I commented on?

@freddii
Copy link
Contributor Author

freddii commented Jan 25, 2021

sadly i deleted the fork. So i am not able to push to this pull request anymore.
So there are 2 solutions:

  1. This gets merged as it is and i will fix the wrong translations in another pull request
  2. i close this pull request and create a new one with the fixes inside it.

@kliment
Copy link
Owner

kliment commented Jan 25, 2021

@freddii I'm happy with either, which way would you prefer?

@freddii
Copy link
Contributor Author

freddii commented Jan 25, 2021

@kliment
Copy link
Owner

kliment commented Jan 25, 2021

Okay, I'll merge this now, and wait for your other PR.

@kliment kliment merged commit dc8c332 into kliment:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants